Wednesday, March 31, 2010

How to steal other people's work and credit

Mr. Min-su, Kim

I have seen the Andriod bug fixing submitted by you in
https://android.git.kernel.org/?p=platform/bionic.git;a=commitdiff;h=0e5e294e978c028aff273afb0a637c73534c8ac2;hp=dbeb84850fcc446db6bc3536aecbf5266b2a36bd

I have did the same fix for Android-x86 last year right after Eclair released and my friend Chih-wei has submitted this fix to google last year. In the fix, I changed DEBUG to LINKERDEBUG and it is because that the Android-X86 has such a special global flag called DEBUG and it conflicts with the original flag defined inside the linker.c. The thing I'm curious most is that in the fix,What was your reason to change the flag name in your first patch set?

it is just an one line fix. But it took me two dame evenings to debug it. So it will be a real shame if you simply just cut and pasted it from us.

Just for your own good, I have a suggestion, next time, when you steal someone's code, please do change something based on the original code (add a ; or space or more empty lines) so that you can insist that you made the code yourself when the original owner bust you,

Yi